search

vendrhub / vendr-checkout

A ready made checkout flow for Vendr, the eCommerce solution for Umbraco v8+
https://vendr.net/add-ons/vendr-checkout/
MIT License
14 stars 17 forks source link

YSOD while accessing an empty cart #6

Closed thomas-jf closed 4 years ago

thomas-jf commented 4 years ago

Hi, I'm getting YSOD with a message "Object reference not set to an instance of an object" in App_Plugins\VendrCheckout\Views\VendrCheckoutInformationPage.cshtml Line: 42

vendrysod

I would rather expect a message "Your cart is empty" or redirect back to the cart (Matt's sugestion on Vendr support)

Regards Tomasz

mattbrailsford commented 4 years ago

Thanks @thomas-jf

I've just pushed a potential fix in commit 7b1c329892315d823f9962a8b53854fec0f4556b although I haven't tested it yet. Your welcome to give the unstable build a try which you can access on our unstable nuget feed at https://nuget.outfield.digital/unstable/vendr/v3/index.json. You'll want the Vendr.Checkout 1.1.5-beta0006 build. Given it's just a background code change, just installing the package should be enough. You don't have to run the installer again.

I'll try and take a look at testing it myself a little later

/Matt

thomas-jf commented 4 years ago

Hi @mattbrailsford

I have just tested 1.1.5-beta0006 build and it looks like it is working better now. I'm redirected to the Checkout Back Page.

/Tomasz

mattbrailsford commented 4 years ago

Awesome! Thanks for test @thomas-jf 👍

I'll try and get an official release out this week / early next.

mattbrailsford commented 4 years ago

Oops, forgot to say, this fix got rolled out last week. Thanks again for reporting 👍