vendrhub / vendr-checkout

A ready made checkout flow for Vendr, the eCommerce solution for Umbraco v8+
https://vendr.net/add-ons/vendr-checkout/
MIT License
14 stars 17 forks source link

Payment method not allowed in current country but listed on checkout page #7

Closed thomas-jf closed 4 years ago

thomas-jf commented 4 years ago

Hi, I don't know if that is a bug or jus a misconfiguration. I have three payment methods:

billede

but Invoicing is not allowed in any countries:

billede

but is listed on the Payment methods checkout page:

billede

"Fortunately" it gives an error, when one tries to use it and falls back to the default pm (Bambora):

billede

Regards Tomasz

mattbrailsford commented 4 years ago

Thanks @thomas-jf that does indeed sound like a bug. I think we must not be filtering the methods that aren’t allowed. We can definitely sort that πŸ‘πŸ»

thomas-jf commented 4 years ago

It isn't something critical to me just right now and I'm sure that I could fix it by my self, but I don't have time right now and I need to do a custom check out flow to the project anyway. (And as a third excuse, I haven't done a pull request to the open source project yet. So it will be the very first time :) )

But I think that Vendr and Vendr.Checkout are awesome and we sure will use them in other projects (we used TC very often).

/Tomasz

mattbrailsford commented 4 years ago

Hey, just spending the time to submit an issue with fully documented replication steps is a great contribution in itself so I appreciate you trying it and taking the time to report it πŸ™

mattbrailsford commented 4 years ago

Should be fixed in commit d8088116bd66a24e6d12f9126af7bdb7e97855bd will be in an upcoming 1.1.6 release πŸ‘