search

vendrhub / vendr-demo-store

Demo store for Vendr, the eCommerce solution for Umbraco v8+
MIT License
25 stars 15 forks source link

Fix paging issue #17

Closed bjarnef closed 2 years ago

bjarnef commented 2 years ago

Currently it multiply with page in the take part of SkipTake() which mean with a page size of 10 it skip 0 and take 10 (page 1), then skip 10 and take 20 (page 2), then skip 20 and take 30 (page 3), etc.

It should only take same number of items for each page.

mattbrailsford commented 2 years ago

Good spot! I think this is a regression from v8 whereby previously you would fetch back all of the results from 0 to the current page, and then those would be filtered by the skipping the first X pages. However the newer API doesn't require this anymore 👍