search

vendure-ecommerce / ngx-translate-extract

Extract translatable (using ngx-translate) strings and save as a JSON or Gettext pot file
MIT License
48 stars 19 forks source link

Feat/accommodate marker pipe, directive and forks #5

Closed colsen1991 closed 1 year ago

colsen1991 commented 1 year ago

See [@colsen1991/ngx-translate-extract-marker] for which usecases this accommodates. But in short it should enable forks of biesbjerg's marker lib, as well as marker pipes and directives.

michaelbromley commented 1 year ago

Hi Christer,

As I mentioned in the other issue - apologies for the slow response! I just published a new version with the other PRs in it, and I see that you've done a lot of work on your fork. If you are willing, I would love to have your contributions here.

The Vendure org is totally willing to maintain this and now that I have notifications enabled (🤦) responses will be timely :)

Let me know if you'd like to update this PR with your latest work!

colsen1991 commented 1 year ago

Thanks for the reply - honest mistake forgetting to enable notifications 😅But yeah, theres a couple of thing that'll need updating in my before PR can be considered for merging. I'll get to it as soon as possible!

On Thu, 2 Mar 2023, 10:09 Michael Bromley, @.***> wrote:

Hi Christer,

As I mentioned in the other issue - apologies for the slow response! I just published a new version with the other PRs in it, and I see that you've done a lot of work on your fork. If you are willing, I would love to have your contributions here.

The Vendure org is totally willing to maintain this and now that I have notifications enabled (🤦) responses will be timely :)

Let me know if you'd like to update this PR with your latest work!

— Reply to this email directly, view it on GitHub https://github.com/vendure-ecommerce/ngx-translate-extract/pull/5#issuecomment-1451532516, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZO5OQO4ID6TNA4C2L2FE3W2BPS3ANCNFSM6AAAAAAUDSWQHI . You are receiving this because you authored the thread.Message ID: @.***>

colsen1991 commented 1 year ago

Aight, @michaelbromley it should be ready; though it turned into a bit of a mess due to some of my refactoring. If it's too much, let me know and I'll make a new and cleaner PR.

As a side note, I'll prepare a branch for you on my ngx-translate-extract-marker fork. Should make it easier for you when you find the time, to fork with branches and just merge it into master and publish :)

Looking forward to your feedback!

michaelbromley commented 1 year ago

Thank you, lots of good stuff here. I'll publish a new minor version today.

Regarding the ngx-translate-extract-marker, what do you think of the idea of making this a monorepo that contains both projects? This would make a lot of sense to me from a maintainability viewpoint, and would still allow us to publish separate npm packages.

colsen1991 commented 1 year ago

@michaelbromley my pleasure!

In regards to a monorepo or not; same same really 😃 It makes sense in terms of maintainability. Though it requires some work to setup and I do not think a lot of new features will be added to the marker lib in the future. Seeing as it is mainly a collection of no-ops. So changes will likely be bumping (angular) dependencies from time to time.

So I'd say just do whatever you feel most comfortable with; I'm fine working with either when the time comes for me to contribute again 👍