search

vendure-ecommerce / ngx-translate-extract

Extract translatable (using ngx-translate) strings and save as a JSON or Gettext pot file
MIT License
51 stars 19 forks source link

Runtime error in 9.3.0 #62

Closed de-don closed 1 week ago

de-don commented 1 week ago

After updating to 9.3.0 from 9.2.1 I faced the issue:

 import pkg, { isPropertyAccessExpression, isCallExpression } from 'typescript';
                                                ^^^^^^^^^^^^^^^^
      SyntaxError: Named export 'isCallExpression' not found. The requested module 'typescript' is a CommonJS module, which may not support all module.exports as named exports.
      CommonJS modules can always be imported via the default export, for example using:

      import pkg from 'typescript';
      const { isPropertyAccessExpression, isCallExpression } = pkg;

          at ModuleJob._instantiate (node:internal/modules/esm/module_job:146:21)
          at async ModuleJob.run (node:internal/modules/esm/module_job:229:5)
          at async ModuleLoader.import (node:internal/modules/esm/loader:473:24)

      Node.js v20.17.0

      Pass --verbose to see the stacktrace.

Versions:

"typescript": "5.4.5",
"@ngx-translate/core": "15.0.0",
"@vendure/ngx-translate-extract": "9.3.0",
pmpak commented 1 week ago

Hello, the issue has been resolved by #60 and will be available in the next release.

michaelbromley commented 1 week ago

v9.3.1 was just published 👍