Closed mitch3s closed 1 year ago
Name | Link |
---|---|
Latest commit | 23e9286af4d91d62f8a7cdc3ca357e6efbe0a642 |
Latest deploy log | https://app.netlify.com/sites/inspiring-boba-355f4d/deploys/640da4001194170007231d08 |
Deploy Preview | https://deploy-preview-34--inspiring-boba-355f4d.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Visit the deploys page to approve it
Name | Link |
---|---|
Latest commit | 23e9286af4d91d62f8a7cdc3ca357e6efbe0a642 |
Visit the deploys page to approve it
Name | Link |
---|---|
Latest commit | 23e9286af4d91d62f8a7cdc3ca357e6efbe0a642 |
Thank you for this huge contribution! I noticed a lot more work than what you have mentioned, e.g. reworking & abstracting the account navbar. This is a big leap forward for the remix storefront and includes some long awaited features & ground-work (e.g. input validation).
I think the modals in particular are great. The modal used to create/edit a new address could be reused in checkout to allow users to create new addresses on the fly.
In terms of address management, setting a default shipping/billing address is still missing. But this is a shortcoming of the remix storefront overall, as these are also missing in the checkout (differentiating between shipping and billing address is missing entirely.).
Another nitpick from me is the fact that the password tab in account management only shows a single button right now. I don't think this is ideal, we could either always display the change password form or use a modal whenever the password tab is selected but stay on the same tab.
In my opinion none of the things I've mentioned are worth addressing immediately, so I'll go ahead and merge these changes. I'll do some updates in the docs in the near future so we can keep track of these things more easily.
cc @michaelbromley, definitely worth mentioning in your Friday reviews :wink:
Thank you for this huge contribution! I noticed a lot more work than what you have mentioned, e.g. reworking & abstracting the account navbar. This is a big leap forward for the remix storefront and includes some long awaited features & ground-work (e.g. input validation).
I think the modals in particular are great. The modal used to create/edit a new address could be reused in checkout to allow users to create new addresses on the fly.
In terms of address management, setting a default shipping/billing address is still missing. But this is a shortcoming of the remix storefront overall, as these are also missing in the checkout (differentiating between shipping and billing address is missing entirely.).
Another nitpick from me is the fact that the password tab in account management only shows a single button right now. I don't think this is ideal, we could either always display the change password form or use a modal whenever the password tab is selected but stay on the same tab.
In my opinion none of the things I've mentioned are worth addressing immediately, so I'll go ahead and merge these changes. I'll do some updates in the docs in the near future so we can keep track of these things more easily.
cc @michaelbromley, definitely worth mentioning in your Friday reviews 😉
Great, thanks for the feedback! 🙂
It would also be good to unify the address form on the checkout page (when not logged in) with the new address form, since most fields and validation are the same. I might still work on that later, for now I was just focusing on the account page.
And regarding the password tab: you're right, it indeed looks a bit strange this way. A modal might fit there, perhaps the button could then be even moved to the first tab entirely.
Nice thanks :)
@mitch3s thank you for these excellent improvements! This is definitely getting a shout-out in my next review post 👍
Rework account page:
I'm quite new to this stack so any feedback for improvements is welcome! Only thing missing from the account page for now is the order history.