vendure-ecommerce / storefront-remix-starter

A storefront starter kit for Vendure built with Remix
https://remix-storefront.vendure.io
188 stars 105 forks source link

Gracefully handle errors, npm audit fix package vulns #43

Closed DanielBiegler closed 1 year ago

DanielBiegler commented 1 year ago

fixes #41

This adds rudimentary error handling in the root.tsx to avoid showing bare errors like mentioned in #41 with specific comment for users to replace it to suit their needs. The current implementations of most components dont include error boundaries which leads to crashing hard i.e. needing the ErrorBoundary in root.tsx

For example the Footer throws an error when the Server doesnt provide collections... Stuff like that would need to be fixed in the long run, same for the cart / nav / etc. The storefront shouldnt crash as hard as it does when the Vendure instance is down. I didnt include this in this PR.

Also a more important thing: According to npm we got 13 high and even one critical vulnerability in the dependencies.

17 vulnerabilities (3 moderate, 13 high, 1 critical)

So I ran npm audit fix which seems to have worked:

$ npm audit fix

added 4 packages, removed 2 packages, changed 38 packages, and audited 1308 packages in 16s

201 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
netlify[bot] commented 1 year ago

Deploy Preview for inspiring-boba-355f4d ready!

Name Link
Latest commit 2dbbf58106e9bb038919d067f34e24e0815ce7b3
Latest deploy log https://app.netlify.com/sites/inspiring-boba-355f4d/deploys/6446a3be1214c40008e41870
Deploy Preview https://deploy-preview-43--inspiring-boba-355f4d.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for remix-vendure ready!

Name Link
Latest commit 2dbbf58106e9bb038919d067f34e24e0815ce7b3
Latest deploy log https://app.netlify.com/sites/remix-vendure/deploys/6446a3bea2d9080008d13bee
Deploy Preview https://deploy-preview-43--remix-vendure.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.