vendure-ecommerce / storefront-remix-starter

A storefront starter kit for Vendure built with Remix
https://remix-storefront.vendure.io
176 stars 93 forks source link

Upgrading to vendure v2 #44

Closed DanielBiegler closed 1 year ago

DanielBiegler commented 1 year ago

This is my PR for holding all the needed changes to make Vendure v2 work with this storefront.

Currently using a brand new Vendure v2.0.0-beta.2 instance for testing.

Relevant Links:

As a helpful overview, I'll list the mentioned differences from Vendures Issue:

Checklist

fixes https://github.com/vendure-ecommerce/storefront-remix-starter/issues/40

netlify[bot] commented 1 year ago

Deploy Preview for remix-vendure ready!

Name Link
Latest commit 0c9c6636cd87d642cdea1291fac67715b835bbca
Latest deploy log https://app.netlify.com/sites/remix-vendure/deploys/646b9a2aa342fa0008ab589d
Deploy Preview https://deploy-preview-44--remix-vendure.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for inspiring-boba-355f4d ready!

Name Link
Latest commit 0c9c6636cd87d642cdea1291fac67715b835bbca
Latest deploy log https://app.netlify.com/sites/inspiring-boba-355f4d/deploys/646b9a2a5e7b1d00086e2c57
Deploy Preview https://deploy-preview-44--inspiring-boba-355f4d.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

DanielBiegler commented 1 year ago

Fixed the orderhistory. It now uses the new FulfillmentLines. Also added placeholder package-tracking buttons.

@michaelbromley is there a readonly demo URL for Vendure v2 maybe? Then we could fix the netlify deployments for public testing. :-)

Header Header
image image
michaelbromley commented 1 year ago

@DanielBiegler great that you are working on this! Currently I don't have a v2 demo running anywhere. I might set one up after the next beta release once I've done the bulk of the Admin UI work I'm in the middle of.

dylviz commented 1 year ago

Looks good! The order history works good on my end as well. I am getting an issue with cart button in the header not responding. It could be related to my backend though, I'm still looking. Is the little cart icon working on your end?

Oops.. looks like I just forgot to run npm i again. All's good!

dylviz commented 1 year ago

Now I'm seeing an error on the /checkout route. Seems like an error on my backend. I noticed a new commit on the major branch 3 days ago maybe it's because I don't have this update

Update: With a fresh backend, I don't see this anymore. Not sure what that was about

kyunal commented 1 year ago

I finally gave it a test run and looked over the changes, everything looks good! I would merge this into a v2 branch for now and would place a hint in the readme file. We can merge everything into main once V2 is released and a demo instance is available.

@DanielBiegler Just mark the PR as ready for review if this sounds good to you and I'll go ahead and do the rest. Thanks for the contribution :raised_hands:

zolzaya commented 1 year ago

I tested it with my current project it's working good :)

michaelbromley commented 1 year ago

πŸ‘ Thank you everyone involved!