search

vendure-ecommerce / vendure

The commerce platform with customization in its DNA.
https://www.vendure.io
Other
5.75k stars 1.02k forks source link

Make apolloserver cache configurable from vendure-config due to DDOS attach risk #1840

Open mariotaran opened 2 years ago

mariotaran commented 2 years ago

This log appears at first bootstrap Persisted queries are enabled and are using an unbounded cache. Your server is vulnerable to denial of service attacks via memory exhaustion. Set cache: "bounded" or persistedQueries: false in your ApolloServer constructor, or see https://go.apollo.dev/s/cache-backends for other alternatives. Persisted queries are enabled and are using an unbounded cache. Your server is vulnerable to denial of service attacks via memory exhaustion. Set cache: "bounded" or persistedQueries: false in your ApolloServer constructor, or see https://go.apollo.dev/s/cache-backends for other alternatives.

I think apolloserver cache should be configurable from vendure-config due to DDOS attach risk

Environment:

giosueDelgado commented 10 months ago

@michaelbromley is possible to take out this settings for apollo in the next minor version?

Thanks