vendure-ecommerce / vendure

The commerce platform with customization in its DNA.
https://www.vendure.io
Other
5.77k stars 1.02k forks source link

Allow Tags to be extended via customFields #1853

Open cermakondrej opened 2 years ago

cermakondrej commented 2 years ago

Is your feature request related to a problem? Please describe. Right now when im using Tags to add them to products via custom fields, they offer very limited features.

Describe the solution you'd like I would like to use them as a limited facets, meaning tagging products such as "New Item" or "HOT sale" or anything like that, giving them colors (potentially gradients etc.) Right now tags cannot be extended with custom fields, so it would require creating new models. Also tags can be right now seamlessly added through Assets, but I think they would deserve their own section and possibility to be added to products (they can be right now through relation-type custom field, but their ui is not recognized as in assets, so tha twould also require additional development which is uncessary, since those ui elements are already in the codebase)

Describe alternatives you've considered I considered using either collections or facets for those type of tags, but in our ecosystem those two are rather used for more structured labeling of products as as categories (Home, garden etc) and label:values such as Brand, Color etc.

michaelbromley commented 2 years ago

Hi, Thanks for the suggestion.

I considered using either collections or facets for those type of tags, but in our ecosystem those two are rather used for more structured labeling of products as as categories (Home, garden etc) and label:values such as Brand, Color etc.

That's exactly what I would suggest to do. In our own projects we handle this the same way - we have Facets for product type, brand, material, etc. But we also use Facets for promotional labels and even for shipping metadata, e.g. we have a "Shipping" Facet with values like "UK Only", "Courier Only" etc.

I added tags as a way to bring some order to the flat-list format of the Asset management experience. Admittedly they are under-utilized right now but I think in this use case, Facets are the right tool for the job.

Having said that, I'm not opposed to adding custom field support to Tags per se.