vendure-ecommerce / vendure

The commerce platform with customization in its DNA.

https://www.vendure.io

MIT License

5.39k stars 943 forks source link

fix(unit-test): Document fix to run Vendure tests on Mac and add rollup #2901

Open mschipperheyn opened 2 weeks ago

mschipperheyn commented 2 weeks ago

Description

I've had problems creating tests for Vendure core. I had to install rollup and deal with a Bindings error. This PR addresses that.

Breaking changes

Checklist

📌 Always:

[ x] I have set a clear title
[x ] My PR is small and contains a single feature
[ x] I have checked my own PR

👍 Most of the time:

[ ] I have added or updated test cases
[ x] I have updated the README if needed

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	Jun 15, 2024 1:40pm

netlify[bot] commented 2 weeks ago

Deploy Preview for effervescent-donut-4977b2 canceled.

Name	Link
Latest commit	a3b22169f1bdc21ac6d6e93f5b71fc7e5f0b3dc9
Latest deploy log	https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/666d99662c8d960008a7d169

michaelbromley commented 2 weeks ago

Hi, are you able to provide any more context around why rollup is required to be added to the root package.json?

mschipperheyn commented 1 week ago

Yes, I had two issues trying to run tests on an M3:

Error: Cannot find module @rollup/rollup-darwin-arm64. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4828). Please try npm i again after removing both package-lock.json and node_modules directory.
Binding errors > fixed with npm rebuild @swc/core

So the first one was resolved with installing rollup. I assume its a transitive dependency. All of these, including the sharp error I get sometimes seem to be related to arm64 specific binding stuff.

michaelbromley commented 1 week ago

Hi Marc, Thanks for the explanation. Looks good to merge but would you be able to rebase onto the latest master first as there is now a conflict in the lockfile.