vendure-ecommerce / vendure

The commerce platform with customization in its DNA.
https://www.vendure.io
Other
5.6k stars 991 forks source link

compileUiExtensions does not work with pnpm #2929

Closed kbanman closed 2 months ago

kbanman commented 2 months ago

Describe the bug Compilation of admin UI fails when the project is set up using pnpm.

[server] ./src/app.module.ts:1:0-35 - Error: Module not found: Error: Can't resolve 'tslib' in '<redacted>/admin-ui/src'
[server] 
[server] ./src/app.module.ts:2:0-41 - Error: Module not found: Error: Can't resolve '@angular/core' in '<redacted>/admin-ui/src'
[server] 
[server] ./src/app.module.ts:3:0-47 - Error: Module not found: Error: Can't resolve '@angular/router' in '<redacted>/admin-ui/src'
[server] 
[server] ./src/app.module.ts:4:0-86 - Error: Module not found: Error: Can't resolve '@vendure/admin-ui/core' in '<redacted>/admin-ui/src'
...

I've tried explicitly installing the admin-ui dependencies, but it still fails with:

./src/global-styles.scss - Error: Module build failed (from ../node_modules/.pnpm/css-loader@6.10.0_webpack@5.90.3_@swc+core@1.4.17_esbuild@0.20.1_/node_modules/css-loader/dist/cjs.js):
Error: Can't resolve '@cds/core/global.min.css' in '<redacted>/admin-ui/src'

./src/global-styles.scss?ngGlobalStyle - Error: Module build failed (from ../node_modules/.pnpm/mini-css-extract-plugin@2.8.1_webpack@5.90.3_@swc+core@1.4.17_esbuild@0.20.1_/node_modules/mini-css-extract-plugin/dist/loader.js):
HookWebpackError: Module build failed (from ../node_modules/.pnpm/css-loader@6.10.0_webpack@5.90.3_@swc+core@1.4.17_esbuild@0.20.1_/node_modules/css-loader/dist/cjs.js):
Error: Can't resolve '@cds/core/global.min.css' in '<redacted>/admin-ui/src'

To Reproduce Steps to reproduce the behavior:

  1. Create a new vendure instance
  2. Switch to using pnpm: rm -rf node_modules package-lock.json && pnpm install
  3. Add compileUiExtensions to the AdminUiPlugin init.
  4. pnpm run dev
  5. See error

Environment:

kbanman commented 2 months ago

Sorry, just found #2876