search

vendure-ecommerce / vendure

The commerce platform with customization in its DNA.
https://www.vendure.io
Other
5.69k stars 1.01k forks source link

Bug Report: "args" Field Not Showing in fulfillmentHandler for shipping method Creation #3062

Closed DAzevedo26 closed 1 month ago

DAzevedo26 commented 1 month ago

Describe the bug While following the tutorial to create a FulfillmentHandler, I encountered an issue where the args field does not appear in the Admin-UI. I followed all the steps as outlined in the tutorial, including correctly defining the args field, but it does not display as expected.

To Reproduce Steps to reproduce the behavior:

  1. Follow the tutorial to create a FulfillmentHandler.
  2. Define the args field as instructed.
  3. Add in vendure-config.ts
  4. Open the Admin-UI to create new shipping method with this fulfillmentHandler

Expected behavior The args field should be visible and configurable in the Admin-UI as part of the FulfillmentHandler.

Environment (please complete the following information):

Additional context fullfilementHandlercodeargs image

dfernandesbsolus commented 1 month ago

@DAzevedo26 I believe the issue is that the shipping method is not expecting arguments and I think it's necessary to adjust the shipment handler to be compatible, similar to a check.

image

@michaelbromley I believe the documentation might be incorrect regarding this. This is crucial for us because we plan to create many shipping plugins with different configurations. Custom fields approach is not ideal as it mixes information. I could modify this to work more like a calculator or check, but that might break compatibility. What are your thoughts?

image