search

vendure-ecommerce / vendure

The commerce platform with customization in its DNA.
https://www.vendure.io
Other
5.79k stars 1.03k forks source link

ngx-translate and unicode-org documentation link #3226

Open xiopipe opened 1 day ago

xiopipe commented 1 day ago

Describe the bug Currently, the ngx-translate and ICU MessageFormat link in the packages/admin-ui/README.md file is incorrect.

To Reproduce Steps to reproduce the behavior:

  1. Go to packages/admin-ui/README.md
  2. Scroll down to #Localization
  3. Click on ngx-translate hyperlink
  4. The ngx-translate hyperliknk link redirects to an unwanted page.
  5. Click on ICU MessageFormat hyperlink
  6. the ICU MessageFormat hyperlink redirects to a 404 not found page.

Expected behavior

  1. The ngx-translate hyperliknk link should redirects to https://ngx-translate.org/
  2. The ICU MessageFormat hyperlink should redirects to https://unicode-org.github.io/icu/userguide/format_parse/messages/
michaelbromley commented 1 day ago

Thanks for the report! Would you be interested in submitting a PR to fix that?

xiopipe commented 1 day ago

Thanks for the report! Would you be interested in submitting a PR to fix that?

I already did it, https://github.com/vendure-ecommerce/vendure/pull/3227 but I think I'm not following the PR rules

dlhck commented 18 hours ago

@xiopipe you do, just need to sign the CLA then we are good to merge.