Arseny, privet !
Looks very good !
I would use same template for GPL license I have in all my files that I
place under vanilla-rtb/rtb , except in exxamples it's ok not to list
formal statement , but I tink
to have this tradition for the framework stack to always include it.
It looks very professional and give people a sense it's not a sandbox
project.
Also, made some comments for communicator.hpp , I think we don't have to
use std::shared_ptr , but please keep your fixes for &&Handler
-> Handler
we don't need universal reference ever, because std::function needs to be
copied it has same semantics as std::shared_ptr it has to be passed by copy.
venediktov
commented
7 years ago
Arseny, privet ! Looks very good ! I would use same template for GPL license I have in all my files that I place under vanilla-rtb/rtb , except in exxamples it's ok not to list formal statement , but I tink to have this tradition for the framework stack to always include it. It looks very professional and give people a sense it's not a sandbox project.
Also, made some comments for communicator.hpp , I think we don't have to use std::shared_ptr , but please keep your fixes for &&Handler
-> Handler
we don't need universal reference ever, because std::function needs to be
copied it has same semantics as std::shared_ptr it has to be passed by copy.
Good work Arseny! Vladimir.
On Fri, Mar 31, 2017 at 3:11 AM, Arseny Bushev notifications@github.com wrote: