search

venediktov / vanilla-rtb

Real Time Bidding (RTB) - Demand Side Platform framework
http://forkbid.com
GNU General Public License v3.0
318 stars 85 forks source link

make BidRequest customization easier #36

Closed venediktov closed 7 years ago

venediktov commented 7 years ago

There is probably a need to support multiple formats even though openRTB is standard. Perhaps we we should provide an easier way to specialize fields and objects even though DSL uses boost::optional for a lot of fields and that allows to skip those automatically when mapping , but using boost::optional is not the best solution as it creates performance overhead .

abushev commented 7 years ago

I think we can declare all those usings in dsl_mapper as public. For now they're not used in our code, but in real bidder dsl_mapper is the only way to get access to those types.

abushev commented 7 years ago

We can even try to implement mapper in google bidding proto. https://developers.google.com/ad-exchange/rtb/downloads/realtime-bidding-proto.txt

venediktov commented 7 years ago

So should we implement google proto buffers in this DSL branch now , or accept pull request and do it next time ?

abushev commented 7 years ago

We can accept it now. Maybe we can add new issue about google protobuf?