Closed venediktov closed 6 years ago
I tested ico_bidder it runs much faster then GEO bidder no surprise .
Everything looks good. But after using referer domain instead of referer url, which makes more sence, its good to rename all the related stuff like referer.hpp, ref_id in ico_campaign.hpp e.t.c to avoid misinform. What do you think?
I thought about it when fixing . It is still referer domain . Domain belongs to referer , right ? If I name class as domain.hpp then are we intend to use it for any domain matching in request ? If so then yes it seems better renaming to domain.hpp
Yea, I think the idea is to make targetings by domain, no matter was it get from referer or any other url.
Great job done!
We have chained_selector trait class to delegate calls from one cache lookup to the next , the return of a lookup becomes input to the next cache lookup.
Outstanding issues \:
This pull request should close issue #74