search

venepe / react-native-music-metadata

6 stars 15 forks source link

wrong @Override method causes cloud build system to fail #6

Open sgeier opened 5 years ago

sgeier commented 5 years ago

Hi,

just wanted to let you know about thw following issue:

Task :react-native-music-metadata:compileReleaseJavaWithJavac FAILED

/Users/runner/runners/2.158.0/work/1/s/node_modules/react-native-music-metadata/android/src/main/java/com/venepe/RNMusicMetadata/RNMusicMetadataPackage.java:26: error: method does not override or implement a method from a supertype @Override ^ 1 error

Removing the Override annotation fixes the problem. It'd be great if you could update the lib or accept a PR if I did one?

Thanks

venepe commented 5 years ago

@sgeier Send the PR over and I will take a look

AliRehman7141 commented 3 years ago

@venepe Any update??