search

veniosg / Dir

A modern File Manager for Android
http://veniosg.github.io/Dir
Apache License 2.0
187 stars 44 forks source link

Adding bookmarks deletion after files with bookmarks are deleted. #131

Closed lamskm closed 4 years ago

lamskm commented 4 years ago

I found that the deletion of the bookmarks have to be next to the DeleteAsyncTask() call within the Single/MultiDeleteDialog() methods, under the same confirmed YES condition. Otherwise, checking for file existence to do bookmark delete may not work (files not yet deleted). I tried to pass a Runnable to Single/MultiDeleteDialog() using a Bundle, but cannot put a Runnable into a Bundle. So I had to add a Runnable to the Single/MultiDeleteDialog() constructors. Please let me know if this can be improved.

-Michael

lamskm commented 4 years ago

Yes I tried both and no crashes happened.

  1. deleting a file with a bookmark
  2. deleting a file without a bookmark (also tried the case of deleting multiple files, some with and some without).

I should have mentioned this in the comment and I forgot.

Thanks.

-Michael

 On Monday, August 24, 2020, 07:33:36 AM PDT, George Venios <notifications@github.com> wrote:

@veniosg approved this pull request.

I assume deleting a file that's not bookmarked doesn't crash now that you've removed the query and the check? Please confirm and I'll be happy to merge :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

veniosg commented 4 years ago

Thanks for confirming, the changes are now merged 👍