search

veniosg / JustSearch

Search from anywhere, skip the bloat
MIT License
38 stars 6 forks source link

Update the way just search is set as the assistant app #30

Open jm355 opened 3 years ago

jm355 commented 3 years ago

I recently installed KISS launcher and decided to try using it as an assistant, and it must have a more up-to-date method of defining itself as the assistant app because even though it was set as the default assistant in settings, when I tried to open the assistant it had a popup to select the default assistant (the same kind of popup as the one that shows up when you haven't selected a default browser, with the "just once"/"always" options and the list of all the potential assistants on my device). I didn't think much of it until I decided I didn't want to use it as an assistant and tried to switch back to Just Search and it didn't work, it still opened up KISS launcher as the assistant. Turns out, it doesn't trigger that default assistant selector, and since KISS was the only other potential assistant I had installed, I had to install the google assistant to trigger it again, at which point I was able to switch back to just search and uninstall google again.

Would it be possible to update how Just Search handles itself as an assistant so that it will trigger that default assistant selector and people don't accidentally lock themselves out of being able to use it?

veniosg commented 3 years ago

Hi, thanks for the report. It almost sounds as if there are two different intents being used by the system, but I've only seen one in the docs so I'm not too sure how to remedy this. Sadly I've had to stop developing this app but if someone was to look into it they could look at KISS' code to find the relevant IntentFilter.

FWIW I can still accept pull requests, and the project should be fairly easy to build if one wanted to get a version with it :)

jm355 commented 3 years ago

Thanks for letting me know! I'm gonna help KISS launcher make their assistant better, since it's still being worked on and is close to what I want for an ideal assistant, so then I can use it instead. That was a super helpful hint on the intentfilter though, I had no idea where to start on helping them add this functionality but that gave me just enough info to find what I needed online and make the change. Thank you!