venmo / DVR

Network testing for Swift
http://blog.soff.es/network-testing-in-swift-with-dvr
MIT License
651 stars 86 forks source link

Compare encoded bodies instead of data when possible Fixes #23 #24

Closed dasmer closed 9 years ago

dasmer commented 9 years ago

We now unwrap the HTTPBody NSDatas into and compare using isEqual

eliperkins commented 9 years ago

Nice fix! One question around variable naming and then :green_apple:

dasmer commented 9 years ago

changed the naming and moved the HTTPBody equality check into into a private function

eliperkins commented 9 years ago

LGTM. :green_apple:

lionel-alves commented 9 years ago

One question then :green_apple:!