search

venmo / DVR

Network testing for Swift
http://blog.soff.es/network-testing-in-swift-with-dvr
MIT License
651 stars 86 forks source link

Restore print() and abort() behavior #27

Closed danthorpe closed 8 years ago

danthorpe commented 8 years ago

See my comments on this commit https://github.com/venmo/DVR/commit/ecabe603c5b01bcb9f84ad8465e1a2f6d118fc75 which replaced print and abort with fatalError.

stephencelis commented 8 years ago

Might be good to note (in this PR and in the commit messages) that this is intended to fix Carthage compatibility (which includes pre-built frameworks directly rather than having the source available). I am surprised that in such a state the fatal errors don't propagate to the console (as they do just fine when embedding the Xcode project directly), so this might be worth opening a bug report with Apple, as well.

danthorpe commented 8 years ago

@stephencelis Oh, interesting. Hmm. I guess it's up to the DVR maintainers to decide what they want to do.

soffes commented 8 years ago

:+1:

soffes commented 8 years ago

I apparently don't have write access any more. Bummer. I'm all for this though. Thanks @danthorpe!

dasmer commented 8 years ago

:green_apple:

danthorpe commented 8 years ago

Hey - pretty happy to see that this got merged - I think it's the most pragmatic solution. Sucks that Xcode can't magically catch fatal errors like this.

Also wanted to say - that my project Money, has been trending recently. I think a big part of its success has been my test coverage (100%), which wouldn't have been possible (or at least, so easy) without DVR. So thanks so much for developing, sharing and maintaining this tool. It's thanks to your team and others that the "quality bar" is being raised by open source software within our community.