Capture session headers in request headers

venmo / DVR

Network testing for Swift

http://blog.soff.es/network-testing-in-swift-with-dvr

MIT License

651 stars 86 forks source link

Capture session headers in request headers #36

Closed hyperspacemark closed 8 years ago

soffes commented 8 years ago

This has been the most profitable PR for me.

soffes commented 8 years ago

Is there a reason to not just merge them into the request before the task is even created? That was the task doesn't have to care about session things.

hyperspacemark commented 8 years ago

@soffes Done. Also added tests.

ayanonagon commented 8 years ago

:green_apple:

eliperkins commented 8 years ago

One little silly nit, but otherwise :green_apple: !