search

venmo / DVR

Network testing for Swift
http://blog.soff.es/network-testing-in-swift-with-dvr
MIT License
651 stars 86 forks source link

Ignore BaseURL option #44

Closed mihaigeorgescu-newstore closed 5 years ago

mihaigeorgescu-newstore commented 8 years ago

This PR adds the possibility to ignore the parts of the url when comparing requests. I added ignoreURLComponents options to the Session. This is useful when you are using two environments, sandbox and production. And the request may have a different scheme, port or host.

mihaigeorgescu-newstore commented 8 years ago

So far nobody is interested in this feature, how do you handle this situations when you have different URL for Sandbox and Production ?

soffes commented 8 years ago

I am very interested in this. I've been busy though. Maybe @hyperspacemark has time to review?

soffes commented 8 years ago

Thanks for your work on this @mihaigeorgescu-newstore!

eliperkins commented 8 years ago

📫

mihaigeorgescu-newstore commented 8 years ago

PR was updated, the url check is performed directly on the URLComponents. @eliperkins could you have another look at it ?

eliperkins commented 5 years ago

Closing as these branches have diverged too far for this PR to be valuable