Clean up test organization for SessionUploadTests

venmo / DVR

Network testing for Swift

http://blog.soff.es/network-testing-in-swift-with-dvr

MIT License

651 stars 86 forks source link

Clean up test organization for SessionUploadTests #51

Closed eliperkins closed 7 years ago

eliperkins commented 8 years ago

Just some general organizational and stylistic clean up. Added XCTFails for some former force unwraps as sanity checks as well.

soffes commented 8 years ago

Personally, I prefer the brevity of force unwraps in testing. The test will still fail or crash if the force fails. :)

eliperkins commented 8 years ago

This is me flailing trying to figure out why tests are failing on Travis but not locally haha. Crashing because of a force unwrap somewhere only in the iOS tests...

eliperkins commented 8 years ago

The Travis logs aren't super helpful... https://travis-ci.org/venmo/DVR/jobs/139790798#L436

soffes commented 8 years ago

Ah fair. Definitely better for CI logs