search

venmo / DVR

Network testing for Swift
http://blog.soff.es/network-testing-in-swift-with-dvr
MIT License
651 stars 86 forks source link

Expose currentRequest in SessionDataTask #70

Closed ocurr closed 4 years ago

ocurr commented 7 years ago

Exposes currentRequest member variable of SessionDataTask in extended SessionDataTask. I'm fairly new to swift so any critiques are very welcome.

getaaron commented 7 years ago

What's the benefit of exposing currentRequest?

ocurr commented 7 years ago

I'm currently using DVR with a networking library that uses currentRequest as part of it's logging cycle. It was easier to have DVR expose it then try to rework the library to use something else. I suppose that this is an edge use case, but I would prefer not to have to maintain a fork just to handle this one difference.

dmiluski commented 4 years ago

Hi @ocurr , this PR was filed quite a long time ago (Sorry for the limited maintenance) and I was running through old tickets and this seemed like it satisfies a goal and could be pulled in.

Seeing if this could be rebased, and I'd be happy to merge.

dmiluski commented 4 years ago

Closing in favor of PR from latest master: https://github.com/venmo/DVR/pull/95