search

venmo / DVR

Network testing for Swift
http://blog.soff.es/network-testing-in-swift-with-dvr
MIT License
651 stars 86 forks source link

Swift package manager support #73

Closed loudmouth closed 6 years ago

loudmouth commented 6 years ago

This PR restructures the repo's directories to enable Swift Package Manager.

It also adds a build job to the travis matrix that ensures swift build is working. Unfortunately, SPM does not enable including other resources (i.e. bundled content) like Xcode so therefore swift test fails as cassettes cannot be found. Once support for bundling other resources with swift build, then we should update the travis script to run swift test.

Lastly, this fixes the travis builds that were broken on master.

Addresses #67

loudmouth commented 6 years ago

Only the iOS build has failed because of the infamous exit code 65 which is a known Xcode bug. Can somebody on the venmo org please restart the build? It should pass.

loudmouth commented 6 years ago

Anything else that needs to be changed before merging?

loudmouth commented 6 years ago

Hey @eliperkins

I've just rebased

loudmouth commented 6 years ago

Shoot...have an issue the iOS build in Travis...will have to fix when i'm back at a computer.

loudmouth commented 6 years ago

@eliperkins it looks like the error code on the iOS build is the infamous error code 65 and that job of the build should just be restarted and it will probably pass.

loudmouth commented 6 years ago

@eliperkins just thought I'd check in on the status of this PR.

Hope you're doing well.

dmiluski commented 6 years ago

Hi @loudmouth, could you rebase once more? There appears to be an Interaction.swift conflict

loudmouth commented 6 years ago

Hey @dmiluski and @eliperkins

I'm really sorry it took me so long to get back to this—it's good to go now!

I had to update some code related to creating the test file for the upload test to pass on iOS, but everything is now green ✅

Any chance we can give this a merge and call it a day?

loudmouth commented 6 years ago

Just a note that we'll still need these two (duplicate) tickets in Swift Package Manager to be addressed for DVR to work with the swift build system on the command line:

SR-2866 SR-4725

Let's upvote there!

loudmouth commented 6 years ago

@eliperkins @kiliankoe @dmiluski

I hope I don't become annoying in doing this, but i'd love to push forward this PR and then continue onto pushing for #80 after I rebase there.

This project is awesome and I use it to test the official Contentful Swift SDK, just wanna help keep it up-to-date and working for us all :-)

loudmouth commented 6 years ago

I think that's all the things. I'll leave it up to you guys at this point :-)

loudmouth commented 6 years ago

@eliperkins @kiliankoe @dmiluski any chance we can merge?

I wanna rebase #80 so that CI passes there.