HTTP status codes not recorded when not 200.

venmo / DVR

Network testing for Swift

http://blog.soff.es/network-testing-in-swift-with-dvr

MIT License

649 stars 87 forks source link

HTTP status codes not recorded when not 200. #74

Closed loudmouth closed 6 years ago

loudmouth commented 7 years ago

My type used for storing errors returned by my API hold the http status code so that user's can get more information while debugging their failed requests. However, when writing acceptance tests that the correct status codes are returned, DVR simply returns HTTP status code 0 always.

It looks like the status code is not being recorded in the cassette.

Any chance we can also record the status code?

loudmouth commented 6 years ago

It appears status codes are not recorded at all anymore.

Also, HTTP headers are now absent for HTTP errors (previously they were present)