search

venmo / DVR

Network testing for Swift
http://blog.soff.es/network-testing-in-swift-with-dvr
MIT License
649 stars 87 forks source link

Fix unrecognized selector error for 'taskIdentifier' and 'originalRequest' methods #77

Open nebiros opened 6 years ago

nebiros commented 6 years ago

Adds support to integrate DVR with Alamofire. Fix: https://github.com/venmo/DVR/pull/41#issuecomment-171917800.

I made a little code snippet about it: https://coderwall.com/p/sd7i2g/my-alamofire-dvr-recipe-for-network-testing-in-swift

eliperkins commented 6 years ago

Hm. Is there more context around what the bug is here? I see you mentioned that there's an unrecognized selector error, but what causes it?

I'd be hesitant to move forward with merging this without knowing who/what is calling on those selectors.

nebiros commented 6 years ago

@eliperkins ouch, sorry, fix this: https://github.com/venmo/DVR/pull/41#issuecomment-171917800, to integrate DVR with Alamofire, I made a little code snippet about it: https://coderwall.com/p/sd7i2g/my-alamofire-dvr-recipe-for-network-testing-in-swift

nebiros commented 6 years ago

@eliperkins any update?

eliperkins commented 6 years ago

I'd love to get other folks eyes on this before merging it, as I don't maintain an up-to-date DVR test suite anymore.

@soffes @hyperspacemark or other contributors, would you mind reviewing this as well?

dmiluski commented 6 years ago

Hi @nebiros , could we update this PR with a description of the problem, the expectation of performance, then how the fix tackles that?

nebiros commented 6 years ago

@dmiluski sure, I update the description

nebiros commented 6 years ago

@dmiluski @eliperkins ping