Debug status code not being recorded

venmo / DVR

Network testing for Swift

http://blog.soff.es/network-testing-in-swift-with-dvr

MIT License

651 stars 86 forks source link

Debug status code not being recorded #80

Closed loudmouth closed 6 years ago

loudmouth commented 6 years ago

Fixes #74 & #69

This PR fixes a regression that caused the http status code and http headers to not be recorded in the case of non-200 responses. I've added a test to avoid future regressions.

loudmouth commented 6 years ago

This PR is ready for review @dmiluski @eliperkins

eliperkins commented 6 years ago

Is the fix in here? It looks like the only changes are in the test files.

loudmouth commented 6 years ago

Hmm, maybe it got lost during rebase...i saw that #75 was merged some time ago, but my fork was still not working. Maybe it's worthwhile to simply add this test and publish a new version?

eliperkins commented 6 years ago

Yeah, adding this test seems kosher to me, especially since it's passing.