venmo / DVR

Network testing for Swift
http://blog.soff.es/network-testing-in-swift-with-dvr
MIT License
651 stars 86 forks source link

More flexible matcher for query string #98

Open YuryLapitsky-TomTom opened 5 months ago

YuryLapitsky-TomTom commented 5 months ago

Hello,

while using the library I faced that cassettes may contain sensitive information (e.g., API keys that are passed with GET request - domain.com?apiKey=XXX) which:

  1. could vary on CI and for local machine
  2. isn't secure to store as a plain JSON in a repo.

Thus, I'd like to add support parametersToIgnore for the Session, so later it could be used for interaction comparison and for removing parameters from the cassette.

Could you confirm if that would be accepted and if that's the case whether the suggested approach makes sense?

And thank you for the nice library, it's very useful for network layer testing.