search

venmo / VENTokenField

Easy-to-use token field that is used in the Venmo app.
MIT License
794 stars 195 forks source link

Fixes scrollView.contentSize resizing #21

Open josipbernat opened 10 years ago

josipbernat commented 10 years ago

When view was dynamically resized, scrollView.contentSize stayed the same. Because of that tokens had wrong layout.

ayanonagon commented 10 years ago

Thank you for this pull-request! I've left some preliminary style comments. I'll play around with the functionality.

josipbernat commented 10 years ago

Sorry for code style, recently I started to use __ for private methods and I really like it. But since this is your code I'll adjust to your code style :)

Btw do I need to make code changes or will you make them?

ayanonagon commented 10 years ago

It would be great if you could make them. :smile:

josipbernat commented 10 years ago

Sorry for delay in responding, done! :)

josipbernat commented 10 years ago

Can you let me know will you merge this request or should I make subclass in my app to fix this issue? Thanks

ayanonagon commented 10 years ago

Hi @josipbernat, sorry for the delay. Can you fix the curly brace style for

- (void)commitLayoutSubviews {

to 

- (void)commitLayoutSubviews
{

and remove the newline after { to be consistent with the rest of the project? Same goes for layoutSubviews. After that, I'll merge. :+1:

Sorry for nitpicking, and thanks again for the PR. :octocat:

josipbernat commented 10 years ago

Sorry for delay in responding. Changed and pushed :)

ayanonagon commented 10 years ago

Thanks for the updates! It looks like the Travis build failed for some reason (weird because all you changed is code style in the last commit). I'll take a look at the stack trace as well. :+1: