search

venmo / VENTokenField

Easy-to-use token field that is used in the Venmo app.
MIT License
794 stars 195 forks source link

Rotation clears inputTextField.text #76

Open walsh2000 opened 9 years ago

walsh2000 commented 9 years ago

Hello

-[VENTokenField layoutInputTextFieldWithCurrentX:currentY:] clears inputTextField.text

This is great for clearing the text field when the user calls reloadData, but when we're laying out because of rotation, it causes us to lose our input.

Would you be open to a PR which keeps the existing behavior of clearing the inputTextField on reloadData, but keeps the entered text on relayout ?

walsh2000 commented 9 years ago

It turns out that the PR could be very simple. We're already passing a boolean for whether to adjust the frame or not. All the cases where we're adjusting the frame we also want the inputTextField cleared, so we could add a parameter to layoutInputTextFieldWithCurrentX & use that to clear/not-clear the text field.

I'll submit a PR. Hopefully you're open to the change.