venmo / venmo-ios-sdk

Make and accept payments in your iOS app via Venmo
MIT License
178 stars 57 forks source link

Bug in Venmo app: "Pay (null) $1" appears when using this SDK #85

Closed rweichler closed 9 years ago

rweichler commented 9 years ago

A picture speaks a thousand words:

Presumably this is because the app does not query Venmo's servers for the firstname and lastname if you try to initialize a payment using a URL scheme. (notice the dash between Murat and Gursoz, instead of it being "Murat Gursoz")

BTW, the URL scheme I used was:

venmosdk://venmo.com?recipients=Murat-Gursoz&txn=pay&note=test

I also tried this scheme, with all of the parameters and it also did not work:

venmosdk://venmo.com?recipients=Murat-Gursoz&txn=pay&note=test&client=ios&app_name=test&app_id=2734&device_id=&app_version=1.3.0
rweichler commented 9 years ago

Actually, there's another nasty bug I noticed when using a URL scheme to open the app.

If you have a passcode/touch ID enabled to lock the app, it asks for you to enter your passcode or touch ID. When you're successfully authenticated, the payment UIPopoverMenu does not show.

Even worse, when you go back to the host app and try again, Venmo asks you to authenticate using Touch ID again.

Through limited testing, this only seems to be an issue with the TouchID auth, not the in-app Venmo 4 digit passcode.

eliperkins commented 9 years ago

The (null) issue should have been resolved by a new version of the Venmo app. We're tracking your second comment via issue #73 for now.

If your first issue still persists, feel free to reopen this issue!