Closed kwaa closed 1 year ago
It looks like the vento package name is already in use. @oscarotero what do you think?
Regarding testing, unfortunately I didn't find the node.js fetch polyfill with file://
support.
Perhaps the dnt test should be disabled directly::
# ./scripts/build_npm.ts
await build({
+ test: false,
...
})
Hey, thanks for this.
Regarding the package name, maybe it can use ventojs
or something similar. What do you think?
And about the test, I guess it can be disabled for Node environments.
Hey, thanks for this. Regarding the package name, maybe it can use
ventojs
or something similar. What do you think?
Okay, looks good.
Almost done. I didn't add an Action, but the example at denoland/dnt should work. (npm packages are untested)
btw, it might be possible to request a vento.js.org domain from js.org also, can I join the lumeland org? 🥺
Sorry, I didn't explain well. I meant disable ONLY this test in Node (but run all other tests). You can use theignore
option for that:
Deno.test({
name: "Print async filters",
ignore: typeof Deno === "undefined"
fn: async () => {...}
});
btw, it might be possible to request a vento.js.org domain from js.org
That would be great. I'm a bit busy right now but feel free to request it.
also, can I join the lumeland org? 🥺
Yeah, sure! I just send you an invitation.
Sorry, I didn't explain well. I meant disable ONLY this test in Node (but run all other tests).
Ok, but typeof Deno
is automatically replaced by dnt with typeof dntShim.Deno
so it won't work. I replaced it with globalThis?.process?.release?.name === "node",
.
That would be great. I'm a bit busy right now but feel free to request it.
Simply put, a CNAME
file needs to be created to point to vento.js.org
and I can do the rest.
The docs will be temporarily unavailable until the PR is merged.
Yeah, sure! I just send you an invitation.
thx!
thanks! btw, I have added the CNAME file
btw, I have added the CNAME file
Hmmm... It looks like the github pages for this repository are not deployed in the same way.
The CNAME file needs to appear in the _site
folder after the lume build, and the build command needs to be changed to deno task build --location=https://vento.js.org
Ok, done
It is currently stuck in the "Print async filters" test of
print.test.ts
.undici for node.js does not support
file://
url, will get a "not implemented yet" error (https://github.com/nodejs/undici/issues/2144)Run the dnt build:
deno run -A scripts/build_npm.ts <version>