Unxpected highlighting for if statement within HTML tag

ventojs / vscode-vento

Vento for Visual Studio Code

MIT License

11 stars 4 forks source link

Unxpected highlighting for if statement within HTML tag #8

Open wjharney opened 3 months ago

wjharney commented 3 months ago

For <a {{ if foo == bar }}attribute{{ /if }}>:

== is two colors
bar is not the same color as foo
/if is not the same color as /if Ideally, both parts of each pair should match.

Also notable, but less distracting, the colors used within an HTML tag do not match the colors used for regular content, particularly the content within the if block (attribute).

oscarotero commented 3 months ago

Yes, I'm aware of this, and it depends on the position of the js code in the HTML:

If it's inside an attribute, treats the vento code as a string.
If it's inside a tag, does what you are saying
If it's outside a tag, it works fine

And as an extra annoying case, if it's inside an attribute and it has quotes, the highlighting interprets these quotes as the end of the attribute:

Unfortunately, I'm not an expert creating VSCode plugins. If anyone want to help with this, I'd appreciate.