ventoy / Ventoy

A new bootable USB solution.
https://www.ventoy.net
GNU General Public License v3.0
62.94k stars 4.1k forks source link

【INTERNAL】Ventoy-1.0.15 Development Plan #266

Closed ventoy closed 4 years ago

ventoy commented 4 years ago

If everything goes well, Ventoy-1.0.15 will be released at 2020/07/11 (checked means done, unchecked means in developing)

New ISO support

kmm2 commented 4 years ago

This could be something simple or perhaps my syntax error but I can not get "persistence" and "control" to work together. Here is my /ventoy/ventoy.json

{
    "control": [
        { "VTOY_DEFAULT_MENU_MODE": "0" },
        { "VTOY_FILT_DOT_UNDERSCORE_FILE": "1" },
        { "VTOY_DEFAULT_SEARCH_ROOT": "/ISO" },
        { "VTOY_MENU_TIMEOUT": "10" },
        { "VTOY_DEFAULT_IMAGE": "/ISO/live.iso" }
    ]

    "persistence" : [
        {
            "image": "/ISO/linuxmint-19.3-xfce-64bit.iso",
            "backend": "/persistence/linuxmint_19.03.img"
        }
    ]
}

To get the "control" items active I need to remove the "persistence" items from the global config. With the "persistence", it behaves as if ventoy.json did not exist. To fix in v1.0.15?

ventoy commented 4 years ago

There is a syntax error in the json (missing a ,)

{
    "control": [
        { "VTOY_DEFAULT_MENU_MODE": "0" },
        { "VTOY_FILT_DOT_UNDERSCORE_FILE": "1" },
        { "VTOY_DEFAULT_SEARCH_ROOT": "/ISO" },
        { "VTOY_MENU_TIMEOUT": "10" },
        { "VTOY_DEFAULT_IMAGE": "/ISO/live.iso" }
    ],

    "persistence" : [
        {
            "image": "/ISO/linuxmint-19.3-xfce-64bit.iso",
            "backend": "/persistence/linuxmint_19.03.img"
        }
    ]
}

When you change the json file, Remember to check it with some online tool, e.g. http://json.parser.online.fr

KaMyKaSii commented 4 years ago

This could be something simple or perhaps my syntax error but I can not get "persistence" and "control" to work together. Here is my /ventoy/ventoy.json

{
    "control": [
        { "VTOY_DEFAULT_MENU_MODE": "0" },
        { "VTOY_FILT_DOT_UNDERSCORE_FILE": "1" },
        { "VTOY_DEFAULT_SEARCH_ROOT": "/ISO" },
        { "VTOY_MENU_TIMEOUT": "10" },
        { "VTOY_DEFAULT_IMAGE": "/ISO/live.iso" }
    ]

    "persistence" : [
        {
            "image": "/ISO/linuxmint-19.3-xfce-64bit.iso",
            "backend": "/persistence/linuxmint_19.03.img"
        }
    ]
}

To get the "control" items active I need to remove the "persistence" items from the global config. With the "persistence", it behaves as if ventoy.json did not exist. To fix in v1.0.15?

Also remove the first blank space after persistence, like this: "persistence": [

kmm2 commented 4 years ago

Thanks so much, it works indeed!

edit - the blank space seems irrelevant.

KaMyKaSii commented 4 years ago

Thanks so much, it works indeed!

edit - the blank space seems irrelevant.

I don't know if there was any change in the parsing of json in the latest versions, but when I started using ventoy.json in Ventoy 1.0.12 removing the blank space was one of the necessary changes to make it work, so I decided to mention it

ventoy commented 4 years ago

The space doesn't matter. The json paser doesn't change for many releases. So 1.0.12 should also ignore the space.

KaMyKaSii commented 4 years ago

The space doesn't matter. The json paser doesn't change for many releases. So 1.0.12 should also ignore the space.

I just tested it and in fact you are right. In this case I recommend that you follow this model (having a blank space to the left of ":" or none) in all examples of the configuration in the docs because keeping them alternate can be confusing for the user

soares23 commented 4 years ago

For the Development Plan's it is maybe better to create a Milestone on Github is easier to find it if there are plenty of issues or Requests. Than you can put all the next features and Date of maybe realease there.

kmm2 commented 4 years ago

Can #258 make it to 1.0.15?

VISHALVODRO commented 4 years ago

Thank you for adding GPT partition style support. It is another major improvement!!! Thank you very much.

kmm2 commented 4 years ago

This will be a great release, perhaps worth a major version jump to 1.1.0

ventoy commented 4 years ago

@kmm2 Ventoy-1.1.0 will be released only after all of the distros in distrowatch.com (or most of them) have been supported :)