search

ventoy / vtoyboot

Work with ventoy to support boot Linux distros in a vdisk file (vhd/vdi/raw ...)
GNU General Public License v3.0
275 stars 23 forks source link

vtoyboot 1.0.22 package incomplete #49

Open cricalix opened 2 years ago

cricalix commented 2 years ago

The artifacts for ventoyboot 1.0.22 are incomplete; there is no ventoyboot subdirectory like in 1.0.21 and earlier.

unzip -t v1.0.22.zip Archive: v1.0.22.zip 58c6314935cb9b53bd14fe5d802b2a66057c5608 testing: vtoyboot-1.0.22/ OK testing: vtoyboot-1.0.22/.github/ OK testing: vtoyboot-1.0.22/.github/workflows/ OK testing: vtoyboot-1.0.22/.github/workflows/sync2gitee.yml OK testing: vtoyboot-1.0.22/LICENSE OK testing: vtoyboot-1.0.22/README.md OK testing: vtoyboot-1.0.22/commonfunc.sh OK testing: vtoyboot-1.0.22/pack.sh OK testing: vtoyboot-1.0.22/toolsbuild.txt OK No errors detected in compressed data of v1.0.22.zip.

ventoy commented 2 years ago

User need to download the ISO file from the release URL and use it. All the scripts are inside the ISO file.

If the user download the source code and use it, it will cause problem. see https://github.com/ventoy/Ventoy/issues/1655 So I delete the source code directory in the git repo, then users will not use it by mistake.

cricalix commented 2 years ago

Ah. The documentation at https://www.ventoy.net/en/plugin_vtoyboot.html says to just download the package and decompress it, then run the script. Since you don't decompress an ISO file, I reasoned that the .tar.gz or the .zip would be the one to download and decompress.

If the ISO is the actual container for the script, perhaps wording more like:

Download the latest release ISO file from https://github.com/ventoy/vtoyboot/releases, mount it on a loopback device, unpack the .tar.gz file, and run the vtoyboot.sh script.

Alternately, can the actual .tar.gz that is the artifact to decompress be placed directly in the releases, instead of stored in an ISO (or as well as, if there is a use case for the ISO)?