search

ventrian / News-Articles

News Articles for DNN has been helping DNN administrators to publish articles and blogs to their DNN portals since 2004.
MIT License
38 stars 24 forks source link

Shadowbox not mobile responsive #55

Open robaxx opened 3 years ago

robaxx commented 3 years ago

Just FYI, the replacement lightbox script is very old and doesn't size images to fit mobile screens. There are heaps of similar scripts that are responsive but I don't know which would best fit the module. A search for 'free responsive lightbox script' brings up heaps.

Timo-Breumelhof commented 3 years ago

I have been using http://chocolat.insipi.de/ lately, what do you think?

robaxx commented 3 years ago

Hi Timo, just having a look at that....

The only issues I can see are that it doesn't appear to support swipe, and that, on a phone, the arrows and buttons are extremely tiny.. i.e. they aren't scaling. Without swiping, one has to find the tiny arrows.

I have done this type of thing once before when I did the lightbox for the Nevoweb store and also in custom Revindex templates I built. I used this one: https://github.com/marekdedic/imagelightbox

The only downside I've found with it is that it doesn't support pinch-zooming. I didn't find any that did 100% of everything at the time and so I went with that one. It does look like it has been getting updates recently, so I need to check it again in detail. Check the demo page and see what you think. Rob

b-creative commented 3 years ago

I have been using http://chocolat.insipi.de/ lately, what do you think?

My problem with many lightbox scripts, incl this one, is that they do not come WCAG2-proof out of the box. For us accessibility is vital. Why not make use of the existing Bootstrap modal possibilities?

Timo-Breumelhof commented 3 years ago

IMO you already can implement any custom lightbox you want. I don't think having a dependency on Bootstrap is good TBH. I use bootstrap 4 for all my sites, but not everybody does.

b-creative commented 3 years ago

That’s true. However DNN is always provided with Bootstrap...

Timo-Breumelhof commented 3 years ago

@b-creative Ehh. I don't think so.. are you talking about jQuery? And the major problem is one uses BS3 the other BS4 or in a while BS5 and those don't go well together..

Timo-Breumelhof commented 3 years ago

Hi Timo, just having a look at that....

The only issues I can see are that it doesn't appear to support swipe, and that, on a phone, the arrows and buttons are extremely tiny.. i.e. they aren't scaling. Without swiping, one has to find the tiny arrows.

The only downside I've found with it is that it doesn't support pinch-zooming. I didn't find any that did 100% of everything at the time and so I went with that one. It does look like it has been getting updates recently, so I need to check it again in detail. Check the demo page and see what you think. Rob

Well, this will always a difficult thing to decide as it's also preference. I don't like the effect that your example hides the image when moving. I guess there is no "correct" choice here..

b-creative commented 3 years ago

@b-creative Ehh. I don't think so.. are you talking about jQuery? And the major problem is one uses BS3 the other BS4 or in a while BS5 and those don't go well together..

True