Create Github Action for Tests

venuu / jsonapi-authorization

Authorization for JSONAPI::Resource

http://www.rubydoc.info/github/venuu/jsonapi-authorization

MIT License

132 stars 59 forks source link

Create Github Action for Tests #137

Closed cloke closed 3 years ago

cloke commented 3 years ago

This will run the tests, but the tests fail which appears to be related to https://github.com/cerebris/jsonapi-resources/issues/1343. Although the reports of the errors are related to rails 6.1 this somehow is reported on these tests.


Failure/Error: require "jsonapi-resources"

NameError:
  uninitialized constant ActionController::ForceSSL

valscion commented 3 years ago

Thanks for taking a stab at this!

Are we somehow able to use the Appraisal generated gemfiles that are here: https://github.com/venuu/jsonapi-authorization/blob/master/.travis.yml ?

I think that would make the GitHub actions work.

valscion commented 3 years ago

Hmm, I wonder why the GitHub actions didn't start. This repo is configured like so:

Would you be able to create another pull request from a branch other than master and allow edit rights to that branch by me via the pull request edit UI? That way I could try to trigger a build by pushing a new commit

cloke commented 3 years ago

Added this pr from a different branch https://github.com/venuu/jsonapi-authorization/pull/138