search

venuu / jsonapi-authorization

Authorization for JSONAPI::Resource
http://www.rubydoc.info/github/venuu/jsonapi-authorization
MIT License
132 stars 59 forks source link

GitHub actions test run #139

Closed valscion closed 3 years ago

valscion commented 3 years ago

Commit from https://github.com/venuu/jsonapi-authorization/pull/138

cloke commented 3 years ago

It looks like the main issue will be working through bundle versions versus ruby versus rails versions. For example, if I run the test against the 4.2 rails version using bundle 1.11 there is a Nokogiri error. If I run bundle 1.11 against the rails 6 version then it fails in other ways. As I am not super familiar with how the appraisals gem works I will need to come back to this later.

valscion commented 3 years ago

Yeah looks like the CI will fail with Rails 4.2. We can drop support for that in the next release so we don't have to get CI working with Rails 4.2.

Looks like the existing Travis steps do run after all, but they fail with Rails 4.2: https://github.com/venuu/jsonapi-authorization/runs/1719931321

Skip_bumping_bundler_and_rake_dependency_·_venuu_jsonapi-authorization_e189c5c
cloke commented 3 years ago

Some additional findings...

Rails 6 tests will pass with Ruby 3 and Ruby 2.7. Rails 5 tests fail with Ruby 3 which is probably expected. I'm still learning how Git Actions work with versions. Ideally we'd specify tests to use ruby "<3" on rails "<6".

valscion commented 3 years ago

We don't need to run with Ruby 3 yet, let's get 2.x Ruby versions running first ☺️ we can then look at adding test suite with Ruby 3.0 in the future once we get the GitHub actions working ☺️