Small fixes for the authorize url

kennethormandy commented 4 years ago

getUrlAuthorize is currently returning the clientSecret after getting support for environment variables
Probably for the best in the meantime, because I shouldn’t have included urlAuthorize in getProviderOptions if it doesn’t exist

With those fixes, overriding the default URL works great.

I like what you came up with for showing the advanced settings too. Thanks!

Now that I have spent a bit more time with the plugin, I realized I could also achieve the same thing by modifying the base url on the provider before wrapping it—but I suppose this is still a way to do the same thing purely through the settings pane, which is convenient.

Mosnar commented 4 years ago

Thanks - will take a look as soon as I can. Out of curiosity, are you on 3.4 yet? Thinking about making the next release for 3.4+ in order to implement the new VueAdminTable, but I'll hold off if you're still on an older version.

kennethormandy commented 4 years ago

Thanks! I’m testing on 3.4+, yes. I’m working on a plugin that needs those admin table components, so I was considering making it for 3.4+ too.

venveo / craft-oauthclient

Small fixes for the authorize url #28