3.0.0 - TypeScript, Testing, and Modernization - Githubissues

venveo / serverless-sharp

Serverless image optimizer for S3, Lambda, and Cloudfront

https://venveo.github.io/serverless-sharp/

MIT License

168 stars 34 forks source link

3.0.0 - TypeScript, Testing, and Modernization #111

Open Mosnar opened 2 years ago

Mosnar commented 2 years ago

To Do

[ ] Replace API Gateway with Lambda URLs
[ ] Update docs
[ ] Validate use of settings.yml file - is there a better approach? (see notes)
[ ] Update TLS usage
[ ] Add error cache TTL

Bugs

[ ] AVIF generation is too slow
[x] Finish testing inputValueProcessor
[ ] Should requested dimensions greater than hard-limit max be capped or rejected? (Currently rejected)

Notes

serverless deprecates the usage of settings.yml, and promotes usage of env files. Would you considering going for the latter option? I can assist maybe if you're ok? (See #121)
I see there is some Makefile and stuff. But the sharp layer for Lambda doesn't really require any building I think (See #121)
TLSv1 <-- still uses this protocol. AWS seems to already recommend 'TLSv1.2_2021' (See #121)

Done

[x] Refactor logging
[x] Refactor dataflow to make use of middleware
[x] Refactor exception handling
[x] Add tests for expected output image sizes (ImageRequest and ImageProcessor)
[x] Refactor input value parser
[x] Fix Types & add definitions
[x] Fix/improve tests
[x] Improve linting and code style
[x] Update Sharp to 0.31.x
[x] Implement bundler for ESM & TS
[x] Convert to TypeScript
[x] Update Serverless Framework
[x] Update Imgix schema
[x] Add Dockerfiles for building/updating Sharp