search

venveo / serverless-sharp

Serverless image optimizer for S3, Lambda, and Cloudfront
https://venveo.github.io/serverless-sharp/
MIT License
168 stars 34 forks source link

Support lossless param #90

Open timkelty opened 3 years ago

timkelty commented 3 years ago

There seems to be some logic for this (https://github.com/venveo/serverless-sharp/blob/master/src/ImageHandler.js#L169-L171) , but passing it as a query param results in a thrown 400/ExpectationType.

Related:

timkelty commented 3 years ago

After further digging, I can get it to accept the param, but it must be a string "true". We should probably coerce to a boolean like Imgix does.

That said, it's hard to tell what or if it is doing anything. I'm not sure what the expected behavior is when lossless is combined with q…

Mosnar commented 3 years ago

This is fixed in this PR: #94