search

veracross / consult

Configuration and secrets management for Rails
MIT License
12 stars 0 forks source link

Suggestion: templates should "be" yaml files, but allow erb template syntax #10

Closed aharpervc closed 6 years ago

aharpervc commented 6 years ago

From the readme: "Templates are ERB files, and as such can do anything ERB can do."

I think we should adjust course a little bit on this. By default, when rails loads config files they are also run through ERB, and therefore even though they a "are" yaml files, you can still do templating. I believe Consult should do the same thing; primarily for consistency (both with rails, but also with consult.yml which already supports ERB templating, as written) but also because my_template.yml.erb loses yaml syntax highlighting, which is a bummer (without extra coercion).

I think this would be a documentation-only change; just say that templates are yaml files that support erb template syntax, just like config files.

sixfeetover commented 6 years ago

I'm good with this change, go for it.