search

veracruz-project / veracruz-docker-image

Development Docker image for the Veracruz privacy-preserving compute project. Veracruz is an adopted project of the Confidential Compute Consortium (CCC).
https://veracruz-project.github.io
MIT License
5 stars 10 forks source link

make rules default to run but also rebuilds even if there are no updates #12

Open ericvh opened 3 years ago

ericvh commented 3 years ago

Describe the bug The make rules in the documentation auto-start the built docker image (and name it). You can argue that isn't the right thing to do...but if I run the make again to restart the image perhaps, it always rebuilds the image (which at the very least includes the last stage 70s package of the image...which it doesn't need to do.

This is because the dependency on the image existing isn't tracked properly in the make file.

To Reproduce Follow instructions

Expected behavior A clear and concise description of what you expected to happen.

ericvh commented 3 years ago

There's some magic here for tracking dependencies of docker images:

But...I'm not sure we should actually have the run rule in the makefile depend on the build. We should expect the user to build and then independently run in the Documentation and that will make this go away.