search

veracrypt / VeraCrypt-DCS

VeraCrypt EFI Bootloader for EFI Windows system encryption (LGPL)
GNU Lesser General Public License v3.0
134 stars 59 forks source link

When typing on the graphical keyboard (circles) only mark the circle for the last key #32

Closed CalculonPrime closed 2 years ago

CalculonPrime commented 2 years ago

I'm reporting this from having used the arrow key navigation (touch "simulation") to enter a password, since actual touch interaction doesn't work (reported separately).

The problem is that if you're entering a long phrase, and the keys are not in a standard keyboard layout (as they are not by default), then you're not going to be able to find the key to press if it's repeated in your password, because the circles are filled up as you type, and the letters are shown inside the circles So, to avoid this problem, you should only keep the last circle touched filled (since you need some visual feedback as you go).

A workaround from the user side would be to supply a background bmp that has letters in it outside the circles, but that would defeat the feature you have that allows the letters/layout to be supplied as configuration in DcsProp, and it would be a lot of work to build such a bmp.

This could be solved in other ways as well, such as by just making the circle thicker, but not completely filled so it no longer obfuscates the letter inside the circle when touched. However, thinking more about this, I'm not sure of the point of keeping all the keys typed marked, since it doesn't really help you enter your password due to the possibility of repeated symbols.

CalculonPrime commented 2 years ago

Superseded by issue https://github.com/veracrypt/VeraCrypt-DCS/issues/33