veracrypt / VeraCrypt

Disk encryption with strong security based on TrueCrypt
https://www.veracrypt.fr
Other
6.75k stars 937 forks source link

Wrong file showing up #860

Closed Mo-Gul closed 2 years ago

Mo-Gul commented 2 years ago

Expected behavior

Show the right file in the file/volume text box (the one shown in the screenshot) (as in previous versions).

When double-clicking an HC file in the explorer window, it should show up in the file text box. The same should be true when selecting a file from "windows search", i.e. hitting the Win key, typing the name of the HC file and selecting it from there.

Observed behavior

The files either show up as <correct path>\%1 (A.) or C:\Windows\system32\%1 (B.), depending on how the file was selected.

Steps to reproduce

I observed two ways to produce wrong file names showing up.

A. Double-click HC file in explorer window B. Choose file from Windows search

  1. hit Windows key
  2. type the filename you are searching for
  3. select the HC file either by clicking on it or by selecting it with the keyboard

Screenshots

Screenshot of the result of B.

image showing part of the VeraCrypt window

Your Environment

Please tell us more about your environment

VeraCrypt version: 1.25.4 (64-bit)

Operating system and version: Windows 10 Version 21H1 (Build 19043.1348)

System type: 64-bit

patrick258 commented 2 years ago

confirmed the same issue on Windows 10 21H2 (build 19044.1415) with CV 1.25.4 (64) msi installer

idrassi commented 2 years ago

Thank you for this report. This is caused by a bug in the MSI installer that writes extra % character in the default value of the registry key HKEY_CLASSES_ROOT\VeraCryptVolume\Shell\open\command.

This issue will be fixed. Meanwhile, you can manually fixed by opening the above registry key in Regedit and then remove the extra %, thus replacing "C:\Program Files\VeraCrypt\\VeraCrypt.exe" /v "%%1" by "C:\Program Files\VeraCrypt\VeraCrypt.exe" /v "%1".

For convenience, I'm attaching a zip file containing a .reg file to run to the fix the issue and its PGP signature. VeraCryptVolume_hc.zip

A new version will be published this week to fix this issue.