comid: Add OVMF metadata to the Measurement type

veraison / corim

CoRIM and CoMID manipulation library and CLI

Apache License 2.0

9 stars 7 forks source link

Closed jraman567 closed 3 months ago

jraman567 commented 6 months ago

SEV-SNP launch digest is a function of OVMF metadata, among others. Therefore, this patch adds support to add it as a reference value to Veraison.

We need this reference value to compute the SEV-SNP launch digest on-demand.

jraman567 commented 6 months ago

Hi there,

Please review this pull request and let me know if I need to make any changes.

I ran make lint; make presubmit.

lint didn't report any errors. However, it needs Golang version 1.21 to complete; golangci-lint needs a minimum of 1.21.

presubmit reported a few errors. However, they are existing errors.

Thank you, @thomas-fossati for the CI patch.

Thank you!

jraman567 commented 6 months ago

Hi @yogeshbdeshpande @thomas-fossati @setrofim ,

I just sent a pull request to add OVMF metadata to CoRIM reference values. Please let me know if it looks good.

Thank you, @thomas-fossati , for fixing the CI issue.

-- Jag

jraman567 commented 5 months ago

Thanks for the feedback, @thomas-fossati ! I'll get back to you with that change.