Open deeglaze opened 2 weeks ago
I don't have permissions to merge. Did we decide I'd become a maintainer in the Veraison call? Or did I just suggest it? @yogeshbdeshpande
I don't have permissions to merge. Did we decide I'd become a maintainer in the Veraison call? Or did I just suggest it? @yogeshbdeshpande
I made you an admin to both veraison/corim
and veraison/cocli
.
I don't have permissions to merge. Did we decide I'd become a maintainer in the Veraison call? Or did I just suggest it? @yogeshbdeshpande
I made you an admin to both
veraison/corim
andveraison/cocli
.
@deeglaze : to your question: Did we decide I'd become a maintainer in the Veraison call?
Yes certainly, as I said in the call, your contributions to Veraison project are highly Welcome & Appreciated!
@deeglaze: Thank you for your changes, look good to me.!
This change also demands a suggested change in the veraison/docs
repository, as we would recommend the usage of Content-type
to be in-line with the CoRIM draft. If you are ok, then please also change:
https://github.com/veraison/docs/blob/main/api/endorsement-provisioning/README.md
and also the associated yaml
file in the same location. Note: I have added you to that repo so you should be able to submit!
I suggest before merging this that we wait for the associated CoRIM PR to be merged.
@deeglaze: Thank you for your changes, look good to me.!
This change also demands a suggested change in the
veraison/docs
repository, as we would recommend the usage ofContent-type
to be in-line with the CoRIM draft. If you are ok, then please also change: https://github.com/veraison/docs/blob/main/api/endorsement-provisioning/README.md
This is not strictly connected. The Content-Type
in the docs is already out of sync with Veraison's implementation and should've been fixed irrespective of this change.
and also the associated
yaml
file in the same location. Note: I have added you to that repo so you should be able to submit!
If Dionna wants to do it, great, but she should not feel obligated to do it :-)
@deeglaze: Thank you for your changes, look good to me.! This change also demands a suggested change in the
veraison/docs
repository, as we would recommend the usage ofContent-type
to be in-line with the CoRIM draft. If you are ok, then please also change: https://github.com/veraison/docs/blob/main/api/endorsement-provisioning/README.mdThis is not strictly connected. The
Content-Type
in the docs is already out of sync with Veraison's implementation and should've been fixed irrespective of this change.and also the associated
yaml
file in the same location. Note: I have added you to that repo so you should be able to submit!If Dionna wants to do it, great, but she should not feel obligated to do it :-)
@deeglaze: Thank you for your changes, look good to me.! This change also demands a suggested change in the
veraison/docs
repository, as we would recommend the usage ofContent-type
to be in-line with the CoRIM draft. If you are ok, then please also change: https://github.com/veraison/docs/blob/main/api/endorsement-provisioning/README.mdThis is not strictly connected. The
Content-Type
in the docs is already out of sync with Veraison's implementation and should've been fixed irrespective of this change. @thomas-fossati I am referring to content-type asContent-Type: application/rim+cbor
which we is part of documentation and also in CoRIM repo and also in apiclient repoand also the associated
yaml
file in the same location. Note: I have added you to that repo so you should be able to submit!If Dionna wants to do it, great, but she should not feel obligated to do it :-)
Top level tags are not interpretable as a COSE object. The protected header content-type is not meant to be application/rim+cbor according to the spec draft (Issue #132).
Support the spec's optional unsigned corim tag in COSE payload.